narendly commented on a change in pull request #751: Implement
getAllMappingUnderPath and getMetadataStoreRealm
URL: https://github.com/apache/helix/pull/751#discussion_r377845516
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/accessor/MetadataStoreRoutingDataReader.java
##########
@@ -35,8 +35,7 @@
* @return a mapping from "metadata store realm addresses" to lists of
"metadata store sharding
* keys", where the sharding keys in a value list all route to the
realm address in the
* key
- * @throws InvalidRoutingDataException - when the routing data is malformed
in any way that
- * disallows a meaningful mapping to be returned
+ * @throws InvalidRoutingDataException - when the routing data is missing
Review comment:
Could we be more specific about this? What does it actually mean to have the
routing data "missing"? Which ZNodes do not exist? Which fields do not exist?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
