NealSun96 commented on a change in pull request #751: Implement
getAllMappingUnderPath and getMetadataStoreRealm
URL: https://github.com/apache/helix/pull/751#discussion_r377854671
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/accessor/ZkRoutingDataReader.java
##########
@@ -85,23 +85,14 @@ public ZkRoutingDataReader(String namespace, String
zkAddress,
"Routing data directory ZNode " +
MetadataStoreRoutingConstants.ROUTING_DATA_PATH
+ " does not exist. Routing ZooKeeper address: " + _zkAddress);
}
- if (children == null || children.isEmpty()) {
- throw new InvalidRoutingDataException(
- "There are no metadata store realms defined. Routing ZooKeeper
address: " + _zkAddress);
- }
for (String child : children) {
Review comment:
Agreed. Changing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
