NealSun96 commented on a change in pull request #751: Implement 
getAllMappingUnderPath and getMetadataStoreRealm
URL: https://github.com/apache/helix/pull/751#discussion_r377990567
 
 

 ##########
 File path: 
helix-rest/src/test/java/org/apache/helix/rest/metadatastore/accessor/TestZkRoutingDataReader.java
 ##########
 @@ -104,11 +104,10 @@ public void testGetRoutingDataMissingMSRDChildren() {
     _baseAccessor.create(MetadataStoreRoutingConstants.ROUTING_DATA_PATH, new 
ZNRecord("test"),
         AccessOption.PERSISTENT);
     try {
-      _zkRoutingDataReader.getRoutingData();
-      Assert.fail("Expecting InvalidRoutingDataException");
+      Map<String, List<String>> routingData = 
_zkRoutingDataReader.getRoutingData();
 
 Review comment:
   Yes. I realized that the constructor was not populating `_routingDataMap`. 
That has been fixed. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to