narendly commented on a change in pull request #757: Add write REST endpoints
to helix rest for metadata store directory
URL: https://github.com/apache/helix/pull/757#discussion_r378420836
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/server/resources/metadatastore/MetadataStoreDirectoryAccessor.java
##########
@@ -84,6 +86,31 @@ public Response getAllMetadataStoreRealms() {
return JSONRepresentation(responseMap);
}
+ @PUT
+ @Path("/metadata-store-realms/{realm}")
+ public Response addMetadataStoreRealm(@PathParam("realm") String realm) {
+ try {
+ LOG.error("updating {} {}", _namespace, realm);
Review comment:
Why is this `error`? Should we make this an info log? And "updating {} {}"
is not detailed enough.
Say something like "Successfully added metadata store realm {} to namespace
{}!"... and put it after the call so we know it succeeded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
