narendly commented on a change in pull request #757: Add write REST endpoints
to helix rest for metadata store directory
URL: https://github.com/apache/helix/pull/757#discussion_r379121271
##########
File path:
helix-rest/src/test/java/org/apache/helix/rest/metadatastore/accessor/TestZkRoutingDataReader.java
##########
@@ -42,12 +42,16 @@
@BeforeClass
public void beforeClass() {
+ ZK_SERVER_MAP.get(ZK_ADDR).getZkClient()
+ .deleteRecursively(MetadataStoreRoutingConstants.ROUTING_DATA_PATH);
Review comment:
Nit: a good addition to this would be a TestHelper.verify() that checks that
the deletion has completed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
