narendly edited a comment on issue #771: Create metadata-store-directory-common and server modules URL: https://github.com/apache/helix/pull/771#issuecomment-587084686 > May be we need a common module instead of calling helix-common. So we can put some sharing components to the common module. There are too many code are duplicated and redundant. I dont think copy the code and change class name is a good idea. I agree that duplicate code is not good practice. That said, however, I think if the direction is to complete separate the metadata store directory module/service from the Apache Helix project, this kind of separation is justified. The reason is that when we actually create a new project for metadata store directory service, we would need the code that bootstraps the server using Jersey in the new project. If we go through the trouble of refactoring and creating yet another new module called `rest-common` or something (which I think is what you meant), then we are creating more work for ourselves doing and undoing the separation. (@dasahcc ).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
