kaisun2000 commented on a change in pull request #765: Add DedicatedZkClient
and update DedicatedZkClientFactory
URL: https://github.com/apache/helix/pull/765#discussion_r381037887
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/factory/SharedZkClientFactory.java
##########
@@ -44,15 +44,17 @@ protected SharedZkClientFactory() {
@Override
public RealmAwareZkClient buildZkClient(
RealmAwareZkClient.RealmAwareZkConnectionConfig connectionConfig,
- RealmAwareZkClient.RealmAwareZkClientConfig clientConfig) {
+ RealmAwareZkClient.RealmAwareZkClientConfig clientConfig,
+ MetadataStoreRoutingData metadataStoreRoutingData) {
// TODO: Implement the logic
// Return an instance of SharedZkClient
return null;
}
@Override
public RealmAwareZkClient buildZkClient(
- RealmAwareZkClient.RealmAwareZkConnectionConfig connectionConfig) {
+ RealmAwareZkClient.RealmAwareZkConnectionConfig connectionConfig,
+ MetadataStoreRoutingData metadataStoreRoutingData) {
Review comment:
@narendly, as discussed offline. I don't think we need this as the
connectionConfig have all the information to construct a rest call to MSDS.
The checking of a dedicated ZKCLient and dedicated ShareZKClient should all
limit to path underlying the sharding key.
Yes, two different sharding keys (cluster) can reside on the same shareded
Zookeeper server. But the zkClient constructed with sharding key one should not
really be able to access zk path underlying the second sharding key (space).
The reason is that later we may need to reshard the keys to different zookeeper
servers, that would be a problem then. "future backward compatibility
problem".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
