narendly commented on a change in pull request #765: Add DedicatedZkClient and
update DedicatedZkClientFactory
URL: https://github.com/apache/helix/pull/765#discussion_r381489584
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/factory/SharedZkClientFactory.java
##########
@@ -44,15 +44,17 @@ protected SharedZkClientFactory() {
@Override
public RealmAwareZkClient buildZkClient(
RealmAwareZkClient.RealmAwareZkConnectionConfig connectionConfig,
- RealmAwareZkClient.RealmAwareZkClientConfig clientConfig) {
+ RealmAwareZkClient.RealmAwareZkClientConfig clientConfig,
+ MetadataStoreRoutingData metadataStoreRoutingData) {
// TODO: Implement the logic
// Return an instance of SharedZkClient
return null;
}
@Override
public RealmAwareZkClient buildZkClient(
- RealmAwareZkClient.RealmAwareZkConnectionConfig connectionConfig) {
+ RealmAwareZkClient.RealmAwareZkConnectionConfig connectionConfig,
+ MetadataStoreRoutingData metadataStoreRoutingData) {
Review comment:
@kaisun2000 Good point. As we discussed in person, this is only put in here
to make the code build. We will remove this from the constructor in a future PR
when the global routing data is available.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
