kaisun2000 commented on a change in pull request #765: Add DedicatedZkClient
and update DedicatedZkClientFactory
URL: https://github.com/apache/helix/pull/765#discussion_r382210119
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/factory/RealmAwareZkClientFactory.java
##########
@@ -30,16 +31,21 @@
* Build a RealmAwareZkClient using specified connection config and client
config.
* @param connectionConfig
* @param clientConfig
+ * @param metadataStoreRoutingData
* @return HelixZkClient
*/
+ // TODO: remove MetadataStoreRoutingData
RealmAwareZkClient
buildZkClient(RealmAwareZkClient.RealmAwareZkConnectionConfig connectionConfig,
- RealmAwareZkClient.RealmAwareZkClientConfig clientConfig);
+ RealmAwareZkClient.RealmAwareZkClientConfig clientConfig,
+ MetadataStoreRoutingData metadataStoreRoutingData);
/**
* Builds a RealmAwareZkClient using specified connection config and default
client config.
* @param connectionConfig
+ * @param metadataStoreRoutingData
* @return RealmAwareZkClient
*/
- RealmAwareZkClient buildZkClient(
- RealmAwareZkClient.RealmAwareZkConnectionConfig connectionConfig);
+ // TODO: remove MetadataStoreRoutingData
+ RealmAwareZkClient
buildZkClient(RealmAwareZkClient.RealmAwareZkConnectionConfig connectionConfig,
Review comment:
Nit. We can provide a default implementation of this one. The default
implementation would call the above one by constructing an default
RealmAwareZkClient.RealmAwareZkClientConfig.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
