kaisun2000 commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory URL: https://github.com/apache/helix/pull/765#discussion_r382218146
########## File path: zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/ZkTestBase.java ########## @@ -0,0 +1,148 @@ +package org.apache.helix.zookeeper.impl; Review comment: There is ZkTestBase in Helix common before. So what is the strategy here. 1/ Are we going to remove that ZkTestBase from Helix common and associated test? 2/ Move ZkTestBase in Helix common and associated test here? 3/ Have two ZKTestBase s and their related test in parallel? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
