narendly commented on a change in pull request #788: WIP: Implement request forwarding for ZkRoutingDataWriter URL: https://github.com/apache/helix/pull/788#discussion_r382287590
########## File path: metadata-store-directory-common/src/main/java/org/apache/helix/msdcommon/constant/MetadataStoreRoutingConstants.java ########## @@ -37,5 +37,6 @@ // Field name in JSON REST response of getting sharding keys. public static final String SHARDING_KEYS = "shardingKeys"; - + // The key for system properties that contains the hostname of an instance + public static final String HOSTNAME_SYSTEM_PROPERTY_KEY = "instance_hostname"; Review comment: Nit: rename to MSDS_SERVER_HOSTNAME_KEY? And for the actual value, let's use "msds_hostname" so it doesn't conflict with some general "instance_hostname" key. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
