NealSun96 commented on a change in pull request #788: WIP: Implement request
forwarding for ZkRoutingDataWriter
URL: https://github.com/apache/helix/pull/788#discussion_r382294591
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/accessor/ZkRoutingDataWriter.java
##########
@@ -77,7 +88,23 @@ public synchronized boolean addMetadataStoreRealm(String
realm) {
return createZkRealm(realm);
}
- // TODO: Forward the request to leader
+ String leaderHostName = _leaderElection.getCurrentLeaderInfo().getId();
+ String url =
+ leaderHostName + "/admin/v2/namespaces/" + _namespace +
"/metadata-store-realms/" + realm;
+ HttpPut putRequest = new HttpPut(url);
+ try {
+ HttpResponse response = _forwardHttpClient.execute(putRequest);
+ if (response.getStatusLine().getStatusCode() != 201) {
+ HttpEntity respEntity = response.getEntity();
+ LOG.error("the forwarded request to leader has failed for
addMetadataStoreRealm: {}",
+ respEntity != null ? EntityUtils.toString(respEntity) : "");
Review comment:
When there's no response body, it is still necessary to log "the forward
request has failed". Constructing it like this reduces duplication.
Maybe I can change "" to "No response body is returned" or something else
meaningful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
