narendly commented on a change in pull request #788: WIP: Implement request
forwarding for ZkRoutingDataWriter
URL: https://github.com/apache/helix/pull/788#discussion_r382335171
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/accessor/ZkRoutingDataWriter.java
##########
@@ -77,7 +88,23 @@ public synchronized boolean addMetadataStoreRealm(String
realm) {
return createZkRealm(realm);
}
- // TODO: Forward the request to leader
+ String leaderHostName = _leaderElection.getCurrentLeaderInfo().getId();
+ String url =
+ leaderHostName + "/admin/v2/namespaces/" + _namespace +
"/metadata-store-realms/" + realm;
+ HttpPut putRequest = new HttpPut(url);
+ try {
+ HttpResponse response = _forwardHttpClient.execute(putRequest);
+ if (response.getStatusLine().getStatusCode() != 201) {
+ HttpEntity respEntity = response.getEntity();
+ LOG.error("the forwarded request to leader has failed for
addMetadataStoreRealm: {}",
+ respEntity != null ? EntityUtils.toString(respEntity) : "");
+ return false;
+ }
+ } catch (IOException e) {
+ LOG.error("the forwarded request to leader raised an exception for
addMetadataStoreRealm", e);
Review comment:
Like this:
`String errorMessage = "The forwarded request from " + (this node's
hostname) + " to leader " + (leader's hostname) + " has failed for
addMetadataStoreRealm()!";
if (respEntity != null) {
errorMessage += " Response: " + EntityUtils.toString(respEntity);
}
LOG. error(errorMessage);`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
