pkuwm commented on a change in pull request #788: WIP: Implement request
forwarding for ZkRoutingDataWriter
URL: https://github.com/apache/helix/pull/788#discussion_r382346148
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/server/resources/metadatastore/MetadataStoreDirectoryAccessor.java
##########
@@ -153,9 +161,13 @@ public Response getShardingKeys(@QueryParam("realm")
String realm) {
public Response addShardingKey(@PathParam("realm") String realm,
@PathParam("sharding-key") String shardingKey) {
try {
- _metadataStoreDirectory.addShardingKey(_namespace, realm, shardingKey);
+ if (!_metadataStoreDirectory.addShardingKey(_namespace, realm,
shardingKey)) {
+ return serverError();
Review comment:
That is for server side. Think about client side: what is response for this?
If you are a user, what would you like to know?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
