narendly commented on a change in pull request #788: Implement request
forwarding for ZkRoutingDataWriter
URL: https://github.com/apache/helix/pull/788#discussion_r384318207
##########
File path:
helix-rest/src/test/java/org/apache/helix/rest/metadatastore/accessor/TestZkRoutingDataWriter.java
##########
@@ -40,15 +41,35 @@
private static final String DUMMY_SHARDING_KEY = "SHARDING_KEY";
private MetadataStoreRoutingDataWriter _zkRoutingDataWriter;
+ // MockWriter is used for testing request forwarding features in non-leader
situations
+ class MockWriter extends ZkRoutingDataWriter {
+ HttpUriRequest calledRequest;
+
+ MockWriter(String namespace, String zkAddress) {
+ super(namespace, zkAddress);
+ }
+
+ // This method does not call super() because the http call should not be
actually made
+ @Override
Review comment:
Shouldn't you make the HTTP call? Otherwise you won't be covering
distributed leader election? I think we **should** make the HTTP call here to
the leader. Otherwise it's not a true integration test.
Or is this meant to be a unit test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
