narendly commented on a change in pull request #788: Implement request
forwarding for ZkRoutingDataWriter
URL: https://github.com/apache/helix/pull/788#discussion_r384313439
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/accessor/ZkRoutingDataWriter.java
##########
@@ -100,44 +128,14 @@ public synchronized boolean addShardingKey(String realm,
String shardingKey) {
if (_zkClient.isClosed()) {
throw new IllegalStateException("ZkClient is closed!");
}
- // If the realm does not exist already, then create the realm
- String realmPath = MetadataStoreRoutingConstants.ROUTING_DATA_PATH + "/"
+ realm;
- if (!_zkClient.exists(realmPath)) {
- // Create the realm
- if (!createZkRealm(realm)) {
- // Failed to create the realm - log and return false
- LOG.error(
- "Failed to add sharding key because ZkRealm creation failed!
Namespace: {}, Realm: {}, Sharding key: {}",
- _namespace, realm, shardingKey);
- return false;
- }
- }
-
- // Add the sharding key to an empty ZNRecord
- ZNRecord znRecord;
- try {
- znRecord = _zkClient.readData(realmPath);
- } catch (Exception e) {
- LOG.error(
- "Failed to read the realm ZNRecord in addShardingKey()! Namespace:
{}, Realm: {}, ShardingKey: {}",
- _namespace, realm, shardingKey, e);
- return false;
- }
-
znRecord.setListField(MetadataStoreRoutingConstants.ZNRECORD_LIST_FIELD_KEY,
- Collections.singletonList(shardingKey));
- try {
- _zkClient.writeData(realmPath, znRecord);
- } catch (Exception e) {
- LOG.error(
- "Failed to write the realm ZNRecord in addShardingKey()!
Namespace: {}, Realm: {}, ShardingKey: {}",
- _namespace, realm, shardingKey, e);
- return false;
- }
- return true;
+ return createZkShardingKey(realm, shardingKey);
}
- // TODO: Forward the request to leader
- return true;
+ String url_suffix =
+ "namespaces/" + _namespace + "/metadata-store-realms/" + realm +
"/sharding-keys/"
+ + shardingKey;
+ return forwardRequestToLeader(url_suffix, "put", "addShardingKey",
+ Response.Status.CREATED.getStatusCode());
Review comment:
Replace string literals.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
