narendly commented on a change in pull request #788: Implement request
forwarding for ZkRoutingDataWriter
URL: https://github.com/apache/helix/pull/788#discussion_r384654806
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/accessor/ZkRoutingDataWriter.java
##########
@@ -77,8 +103,9 @@ public synchronized boolean addMetadataStoreRealm(String
realm) {
return createZkRealm(realm);
}
- // TODO: Forward the request to leader
- return true;
+ String url_suffix = "namespaces/" + _namespace + "/metadata-store-realms/"
+ realm;
Review comment:
1. I do see a lot of duplication here. It seems it's possible to achieve the
refactoring. Let me sync with you privately.
2. If you don't have them, you can create them. That's what the constant
file is for. Please clearly note what they are used for.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
