NealSun96 commented on a change in pull request #788: Implement request
forwarding for ZkRoutingDataWriter
URL: https://github.com/apache/helix/pull/788#discussion_r384660621
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/accessor/ZkRoutingDataWriter.java
##########
@@ -77,8 +103,9 @@ public synchronized boolean addMetadataStoreRealm(String
realm) {
return createZkRealm(realm);
}
- // TODO: Forward the request to leader
- return true;
+ String url_suffix = "namespaces/" + _namespace + "/metadata-store-realms/"
+ realm;
Review comment:
Resolved by offline discussion. A method that joins parameters will be used
for url suffix building.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
