narendly commented on a change in pull request #788: Implement request
forwarding for ZkRoutingDataWriter
URL: https://github.com/apache/helix/pull/788#discussion_r384764197
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/accessor/ZkRoutingDataWriter.java
##########
@@ -62,10 +77,24 @@ public ZkRoutingDataWriter(String namespace, String
zkAddress) {
}
// Get the hostname (REST endpoint) from System property
- // TODO: Fill in when Helix REST implementations are ready
- ZNRecord myServerInfo = new ZNRecord("dummy hostname");
+ _myHostName =
System.getProperty(MetadataStoreRoutingConstants.MSDS_SERVER_HOSTNAME_KEY);
+ if (_myHostName == null || _myHostName.isEmpty()) {
+ throw new IllegalStateException(
+ "Unable to get the hostname of this server instance.
System.getProperty fails to fetch "
+ + MetadataStoreRoutingConstants.MSDS_SERVER_HOSTNAME_KEY + ".");
+ }
+ ZNRecord myServerInfo = new ZNRecord(_myHostName);
+
_leaderElection = new ZkDistributedLeaderElection(_zkClient,
MetadataStoreRoutingConstants.LEADER_ELECTION_ZNODE, myServerInfo);
+
+ RequestConfig config = RequestConfig.custom()
+
.setConnectTimeout(MetadataStoreRoutingConstants.HTTP_REQUEST_FORWARDING_TIMEOUT
* 1000)
+ .setConnectionRequestTimeout(
+ MetadataStoreRoutingConstants.HTTP_REQUEST_FORWARDING_TIMEOUT *
1000)
+
.setSocketTimeout(MetadataStoreRoutingConstants.HTTP_REQUEST_FORWARDING_TIMEOUT
* 1000)
Review comment:
Is there a strong and compelling reason why you couldn't include * 1000 in
the constant itself?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
