narendly commented on a change in pull request #788: Implement request
forwarding for ZkRoutingDataWriter
URL: https://github.com/apache/helix/pull/788#discussion_r384767269
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/accessor/ZkRoutingDataWriter.java
##########
@@ -249,4 +244,126 @@ private boolean createZkRealm(String realm) {
return true;
}
+
+ protected boolean deleteZkRealm(String realm) {
+ return _zkClient.delete(MetadataStoreRoutingConstants.ROUTING_DATA_PATH +
"/" + realm);
+ }
+
+ protected boolean createZkShardingKey(String realm, String shardingKey) {
+ // If the realm does not exist already, then create the realm
+ String realmPath = MetadataStoreRoutingConstants.ROUTING_DATA_PATH + "/" +
realm;
+ if (!_zkClient.exists(realmPath)) {
+ // Create the realm
+ if (!createZkRealm(realm)) {
+ // Failed to create the realm - log and return false
+ LOG.error(
+ "Failed to add sharding key because ZkRealm creation failed!
Namespace: {}, Realm: {}, Sharding key: {}",
+ _namespace, realm, shardingKey);
+ return false;
+ }
+ }
+
+ ZNRecord znRecord;
+ try {
+ znRecord = _zkClient.readData(realmPath);
+ } catch (Exception e) {
+ LOG.error(
+ "Failed to read the realm ZNRecord in addShardingKey()! Namespace:
{}, Realm: {}, ShardingKey: {}",
+ _namespace, realm, shardingKey, e);
+ return false;
+ }
+ List<String> shardingKeys =
+
znRecord.getListField(MetadataStoreRoutingConstants.ZNRECORD_LIST_FIELD_KEY);
+ if (shardingKeys == null || shardingKeys.isEmpty()) {
+ shardingKeys = new ArrayList<>();
+ }
+ shardingKeys.add(shardingKey);
+
znRecord.setListField(MetadataStoreRoutingConstants.ZNRECORD_LIST_FIELD_KEY,
shardingKeys);
+ try {
+ _zkClient.writeData(realmPath, znRecord);
+ } catch (Exception e) {
+ LOG.error(
+ "Failed to write the realm ZNRecord in addShardingKey()! Namespace:
{}, Realm: {}, ShardingKey: {}",
+ _namespace, realm, shardingKey, e);
+ return false;
+ }
+ return true;
+ }
+
+ protected boolean deleteZkShardingKey(String realm, String shardingKey) {
+ ZNRecord znRecord =
+ _zkClient.readData(MetadataStoreRoutingConstants.ROUTING_DATA_PATH +
"/" + realm, true);
+ if (znRecord == null || !znRecord
+ .getListField(MetadataStoreRoutingConstants.ZNRECORD_LIST_FIELD_KEY)
+ .contains(shardingKey)) {
+ // This realm does not exist or shardingKey doesn't exist. Return true!
+ return true;
+ }
+
znRecord.getListField(MetadataStoreRoutingConstants.ZNRECORD_LIST_FIELD_KEY)
+ .remove(shardingKey);
+ // Overwrite this ZNRecord with the sharding key removed
+ try {
+ _zkClient.writeData(MetadataStoreRoutingConstants.ROUTING_DATA_PATH +
"/" + realm, znRecord);
+ } catch (Exception e) {
+ LOG.error(
+ "Failed to write the data back in deleteShardingKey()! Namespace:
{}, Realm: {}, ShardingKey: {}",
+ _namespace, realm, shardingKey, e);
+ return false;
+ }
+ return true;
+ }
+
+ private String constructUrlSuffix(String... urlParams) {
+ List<String> allUrlParameters = new ArrayList<>(
+
Arrays.asList(MetadataStoreRoutingConstants.MSDS_NAMESPACES_URL_PREFIX,
_namespace));
+ allUrlParameters.addAll(Arrays.asList(urlParams));
+ // HttpUriRequest will convert all double slashes to single slashes
Review comment:
Do not rely on this behavior. Let's make sure this method creates a valid
URL.
Do you think making this assumption is hacky? Could we improve it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
