NealSun96 opened a new pull request #829: Fix bugs in ZkRoutingDataReader and ZkRoutingDataWriter URL: https://github.com/apache/helix/pull/829 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR description: Fixes #828 ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: This PR fixes the following bugs: 1. When the routing data is not initialized for a namespace, creating a `ZkRoutingDataReader` for that namespace causes a NoNodeException due to a `getChildren` call. Fix: initialize the base node for routing data across all zookeeper-related actors (`ZkMetadataStoreDirectory`, `ZkRoutingDataReader`, `ZkRoutingDataWriter`) 2. In the `getRoutingData()` method of `ZkRoutingDataReader`, a null check is necessary before getting sharding keys from a realm node, because the realm node may be an invalid ZNRecord. Fix: add null check. 3. The hostname provided from system properties does not have the protocol. `ZkRoutingDataWriter` was using the hostname directly for request forwarding. Fix: add protocol to the hostname before request forwarding. ### Tests - [x] The following is the result of the "mvn test" command on the appropriate module: [INFO] Tests run: 136, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.201 s - in TestSuite [INFO] [INFO] Results: [INFO] [INFO] Tests run: 136, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 52.954 s [INFO] Finished at: 2020-02-27T12:06:15-08:00 [INFO] ------------------------------------------------------------------------ ### Commits - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - [x] My diff has been formatted using helix-style.xml
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
