narendly commented on a change in pull request #829: Fix bugs in
ZkRoutingDataReader and ZkRoutingDataWriter
URL: https://github.com/apache/helix/pull/829#discussion_r385441788
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/accessor/ZkRoutingDataReader.java
##########
@@ -128,17 +142,7 @@ public synchronized void handleDataDeleted(String s) {
@Override
public synchronized void handleChildChange(String s, List<String> list) {
- if (_zkClient.isClosed()) {
- return;
- }
-
- // Subscribe data changes again because some children might have been
deleted or added
- _zkClient.unsubscribeAll();
- for (String child :
_zkClient.getChildren(MetadataStoreRoutingConstants.ROUTING_DATA_PATH)) {
-
_zkClient.subscribeDataChanges(MetadataStoreRoutingConstants.ROUTING_DATA_PATH
+ "/" + child,
- this);
- }
- _routingDataListener.refreshRoutingData(_namespace);
+ handleDataDeleted(s);
Review comment:
Please refactor the logic out into a private method and call it
`handleResubscription()` and call it in both of these methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
