jiajunwang commented on a change in pull request #827: Add intermediate storage for customized state URL: https://github.com/apache/helix/pull/827#discussion_r385423566
########## File path: helix-core/src/main/java/org/apache/helix/controller/stages/CustomizedStateOutput.java ########## @@ -0,0 +1,135 @@ +package org.apache.helix.controller.stages; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import java.util.Collections; +import java.util.HashMap; +import java.util.Map; +import java.util.Set; +import org.apache.helix.model.CustomizedState; +import org.apache.helix.model.Partition; + +public class CustomizedStateOutput { + // stateType -> (resourceName -> (Partition -> (instanceName -> customizedState))) + private final Map<String, Map<String, Map<Partition, Map<String, String>>>> _customizedStateMap; Review comment: This map is long and potentially introduces duplicate code since we have a similar code for the current state. Can we abstract a type for the stateMap that covers (resourceName -> (Partition -> (instanceName -> customizedState))) section? Then this map class can be used in both CustomizedStateOutput and CurrentStateOutput. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
