jiajunwang commented on a change in pull request #827: Add intermediate storage
for customized state
URL: https://github.com/apache/helix/pull/827#discussion_r385966377
##########
File path:
helix-core/src/main/java/org/apache/helix/common/caches/AbstractDataCache.java
##########
@@ -43,8 +47,13 @@
protected ControlContextProvider _controlContextProvider;
+ protected Map<String, Map<String, Map<String, T>>> _participantStateMap;
+
+ protected Map<PropertyKey, T> _participantStateCache = Maps.newHashMap();
+
public AbstractDataCache(ControlContextProvider controlContextProvider) {
Review comment:
Thanks for the change. Looks great.
One suggestion is that this change will reduce the genericity of
AbstractDataCache. Can we add a middle class called
"AbstractParticipantStateCache" as a child class of the AbstractDataCache?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
