kaisun2000 commented on a change in pull request #819: Make DedicatedZkClient
use HttpRoutingDataReader for routing data
URL: https://github.com/apache/helix/pull/819#discussion_r385445067
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/factory/RealmAwareZkClientFactory.java
##########
@@ -31,25 +34,21 @@
* Build a RealmAwareZkClient using specified connection config and client
config.
* @param connectionConfig
* @param clientConfig
- * @param metadataStoreRoutingData
* @return HelixZkClient
Review comment:
Document when/why IOExeption would be thrown and why
InvalidRoutingDataException would be thrown.
Seem from HttpRoutingDataReader code, if we can't get data/parse data from
http respone, it would be IO exception, if constructing the trie based on parse
http reponse failed, it is InvalidRoutingDataException.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
