narendly commented on a change in pull request #819: Make DedicatedZkClient use
HttpRoutingDataReader for routing data
URL: https://github.com/apache/helix/pull/819#discussion_r385472899
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/factory/SharedZkClientFactory.java
##########
@@ -45,21 +45,12 @@ protected SharedZkClientFactory() {
@Override
public RealmAwareZkClient buildZkClient(
RealmAwareZkClient.RealmAwareZkConnectionConfig connectionConfig,
- RealmAwareZkClient.RealmAwareZkClientConfig clientConfig,
- MetadataStoreRoutingData metadataStoreRoutingData) {
+ RealmAwareZkClient.RealmAwareZkClientConfig clientConfig) {
Review comment:
No worries.
I won't merge this in until other ZkClients have been merged in. I might
include other ZkClients in the scope of this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
