kaisun2000 commented on issue #789: Add FederatedZkClient URL: https://github.com/apache/helix/pull/789#issuecomment-592786717 As discussed, two concerns: 1/ I think the "checkClosedState()" in the getZkClient is not needed for correctness. In fact, I am not sure how to reason it is correct. Put it this way, I don't know if it is correct or not. 2/ Need a test case to ensure now Zookeeper session is leaking after close() is called.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
