narendly commented on a change in pull request #789: Add FederatedZkClient URL: https://github.com/apache/helix/pull/789#discussion_r386010396
########## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/FederatedZkClient.java ########## @@ -19,345 +19,535 @@ * under the License. */ +import java.util.Iterator; import java.util.List; +import java.util.Map; +import java.util.NoSuchElementException; +import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.TimeUnit; +import com.sun.istack.internal.NotNull; Review comment: Can we not include this? I understand what you're trying to do here, but I don't think you're using this particular annotation the right way. See https://stackoverflow.com/questions/42576760/where-is-notnull-in-java We don't have to use that annotation here... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
