NealSun96 commented on a change in pull request #844: Implement setRoutingData
for MetadataStoreDirectoryService
URL: https://github.com/apache/helix/pull/844#discussion_r387214326
##########
File path:
helix-rest/src/test/java/org/apache/helix/rest/metadatastore/accessor/TestZkRoutingDataReader.java
##########
@@ -130,17 +116,11 @@ public void testGetRoutingDataMSRDChildEmptyValue() {
}
}
- private void deleteRoutingDataPath() throws Exception {
- Assert.assertTrue(TestHelper.verify(() -> {
- ZK_SERVER_MAP.get(ZK_ADDR).getZkClient()
- .deleteRecursively(MetadataStoreRoutingConstants.ROUTING_DATA_PATH);
-
- if (ZK_SERVER_MAP.get(ZK_ADDR).getZkClient()
- .exists(MetadataStoreRoutingConstants.ROUTING_DATA_PATH)) {
- return false;
- }
-
- return true;
- }, TestHelper.WAIT_DURATION), "Routing data path should be deleted after
the tests.");
+ private void clearRoutingDataPath() {
+ for (String zkRealm : _baseAccessor
+ .getChildNames(MetadataStoreRoutingConstants.ROUTING_DATA_PATH,
AccessOption.PERSISTENT)) {
+ _baseAccessor.remove(MetadataStoreRoutingConstants.ROUTING_DATA_PATH +
"/" + zkRealm,
+ AccessOption.PERSISTENT);
Review comment:
Resolved offline. Using `HelixZkClient` and will migrate later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
