NealSun96 commented on a change in pull request #844: Implement setRoutingData
for MetadataStoreDirectoryService
URL: https://github.com/apache/helix/pull/844#discussion_r387233329
##########
File path:
metadata-store-directory-common/src/main/java/org/apache/helix/msdcommon/datamodel/TrieRoutingData.java
##########
@@ -167,8 +167,8 @@ private TrieNode getLongestPrefixNodeAlongPath(String
path) {
}
/*
- * Checks for the edge case when the only sharding key in provided routing
data is the delimiter
- * or an empty string. When this is the case, the trie is valid and contains
only one node, which
+ * Checks for the edge case when the only sharding key in provided routing
data is the delimiter.
+ * When this is the case, the trie is valid and contains only one node, which
Review comment:
The comment change here was regarding to the sharding key being either "/"
or "", not routing data being empty. I believe your question is about when the
entire routing data is empty: the answer is yes, we throw an exception. That
behavior, as we agreed on, will not be changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
