jiajunwang commented on a change in pull request #827: Add intermediate storage
for customized state
URL: https://github.com/apache/helix/pull/827#discussion_r387861358
##########
File path:
helix-core/src/main/java/org/apache/helix/common/caches/CurrentStateCache.java
##########
@@ -55,149 +46,33 @@ public CurrentStateCache(String clusterName) {
public CurrentStateCache(ControlContextProvider contextProvider) {
super(contextProvider);
- _currentStateMap = Collections.emptyMap();
- _snapshot = new CurrentStateSnapshot(_currentStateCache);
+ _snapshot = new CurrentStateSnapshot(_participantStateCache);
Review comment:
The original logic is actually confusing here. Passing an empty new map here
is much easier for people to understand.
Since it won't change the logic, I suggest you just change it to make it
clean : )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
