jiajunwang commented on a change in pull request #849: Add REST APIs for get,
set, update RestConfig
URL: https://github.com/apache/helix/pull/849#discussion_r388500769
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ClusterAccessor.java
##########
@@ -511,6 +512,89 @@ public Response
removeClusterStateModelDefinition(@PathParam("clusterId") String
return OK();
}
+ @PUT
+ @Path("{clusterId}/restconfig")
+ public Response createClusterRESTConfig(@PathParam("clusterId") String
clusterId,
+ String content) {
+ ZNRecord record;
+ try {
+ record = toZNRecord(content);
+ } catch (IOException e) {
+ _logger.error("Failed to deserialize user's input " + content + ",
Exception: " + e);
+ return badRequest("Input is not a valid ZNRecord!");
+ }
+
+ if (!record.getId().equals(clusterId)) {
+ return badRequest("ID does not match the cluster name in input!");
+ }
+
+ RESTConfig config = new RESTConfig(record);
+ ConfigAccessor configAccessor = getConfigAccessor();
+ try {
+ configAccessor.setRESTConfig(clusterId, config);
+ } catch (HelixException ex) {
+ return notFound(ex.getMessage());
Review comment:
It's better to have a more precise exception for notFound error. Or, if we
use HelixException, we should use a more generic error accordingly.
Since this is a common issue, I'm fine if you add a TODO here. We can
address this later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
