narendly commented on a change in pull request #849: Add REST APIs for get,
set, update RestConfig
URL: https://github.com/apache/helix/pull/849#discussion_r389915590
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ClusterAccessor.java
##########
@@ -511,6 +512,125 @@ public Response
removeClusterStateModelDefinition(@PathParam("clusterId") String
return OK();
}
+ @PUT
+ @Path("{clusterId}/restconfig")
+ public Response createClusterRESTConfig(@PathParam("clusterId") String
clusterId,
+ String content) {
+ ZNRecord record;
+ try {
+ record = toZNRecord(content);
+ } catch (IOException e) {
+ _logger.error("Failed to deserialize user's input " + content + ",
Exception: " + e);
+ return badRequest("Input is not a valid ZNRecord!");
+ }
+
+ if (!record.getId().equals(clusterId)) {
+ return badRequest("ID does not match the cluster name in input!");
+ }
+
+ RESTConfig config = new RESTConfig(record);
+ ConfigAccessor configAccessor = getConfigAccessor();
+ try {
+ configAccessor.setRESTConfig(clusterId, config);
+ } catch (HelixException ex) {
+ // TODO: Could use a more generic error for HelixException
+ return notFound(ex.getMessage());
+ } catch (Exception ex) {
+ _logger.error("Failed to create rest config, cluster " + clusterId + "
new config: " + content
+ + ", Exception: " + ex);
+ return serverError(ex);
+ }
+ return OK();
+ }
+
+ @POST
+ @Path("{clusterId}/restconfig")
+ public Response updateClusterRESTConfig(@PathParam("clusterId") String
clusterId,
+ @QueryParam("command") String commandStr, String content) {
+ Command command;
+ try {
+ command = getCommand(commandStr);
+ } catch (HelixException ex) {
+ return badRequest(ex.getMessage());
+ }
+
+ ZNRecord record;
+ try {
+ record = toZNRecord(content);
+ } catch (IOException e) {
+ _logger.error("Failed to deserialize user's input " + content + ",
Exception: " + e);
+ return badRequest("Input is not a valid ZNRecord!");
+ }
+
+ if (!record.getId().equals(clusterId)) {
+ return badRequest("ID does not match the cluster name in input!");
+ }
Review comment:
Could we double-check if the ID for the restConfig is supposed to match up
with the cluster name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
