jiajunwang commented on a change in pull request #851: Add customized view computation and modify Helix generic controller to include new stage URL: https://github.com/apache/helix/pull/851#discussion_r388642767
########## File path: helix-core/src/main/java/org/apache/helix/controller/dataproviders/BaseControllerDataProvider.java ########## @@ -96,13 +99,15 @@ // Special caches private CurrentStateCache _currentStateCache; + private CustomizedStateCache _customizedStateCache; Review comment: We aggregate _currentStateCache in addition to externalView because it is used in the rebalance pipeline. For customize state though, the customized view is the only thing we need. Can we just combine these 2 refresh workflow and keep one customized View map in the cache? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
