jiajunwang commented on a change in pull request #851: Add customized view
computation and modify Helix generic controller to include new stage
URL: https://github.com/apache/helix/pull/851#discussion_r388614743
##########
File path:
helix-core/src/main/java/org/apache/helix/common/caches/CustomizedStateCache.java
##########
@@ -49,11 +49,15 @@ public CustomizedStateCache(ControlContextProvider
contextProvider) {
Map<String, LiveInstance> liveInstanceMap) {
Set<PropertyKey> participantStateKeys = new HashSet<>();
PropertyKey.Builder keyBuilder = accessor.keyBuilder();
- Set<String> restrictedKeys = new HashSet<>(
-
accessor.getProperty(accessor.keyBuilder().customizedStateAggregationConfig()).getRecord()
- .getListFields().get(
-
CustomizedStateAggregationConfig.CustomizedStateAggregationProperty.AGGREGATION_ENABLED_TYPES
- .name()));
+
+ Set<String> restrictedKeys = new HashSet<>();
+ if
(accessor.getProperty(accessor.keyBuilder().customizedStateAggregationConfig())
!= null) {
+ restrictedKeys = new HashSet<>(
+
accessor.getProperty(accessor.keyBuilder().customizedStateAggregationConfig()).getRecord()
+ .getListFields().get(
+
CustomizedStateAggregationConfig.CustomizedStateAggregationProperty.AGGREGATION_ENABLED_TYPES
Review comment:
So if the config is empty, the default behavior is aggregating nothing,
right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
