jiajunwang commented on a change in pull request #872: Change the cluster
creation logic
URL: https://github.com/apache/helix/pull/872#discussion_r388722646
##########
File path: helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java
##########
@@ -189,6 +189,16 @@ public void addCluster(String clusterName, boolean
overwritePrevious, CloudConfi
if (cloudConfig != null) {
_admin.addCloudConfig(clusterName, cloudConfig);
+ // If cloud is enabled and Cloud Provider is Azure, populated the
Topology information in cluster config
+ if (cloudConfig.isCloudEnabled()
Review comment:
1. Can we update the cloudconfig first then add it to the cluster? So that
we have only one ZK access.
2. If the following config is required for AZURE, shall we add it to a more
fundamental method instead of the tool? What if the user call the other API or
admin method to create a cluster that is not compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
