alirezazamani commented on a change in pull request #872: Change the cluster
creation logic
URL: https://github.com/apache/helix/pull/872#discussion_r389047744
##########
File path: helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java
##########
@@ -189,6 +189,16 @@ public void addCluster(String clusterName, boolean
overwritePrevious, CloudConfi
if (cloudConfig != null) {
_admin.addCloudConfig(clusterName, cloudConfig);
+ // If cloud is enabled and Cloud Provider is Azure, populated the
Topology information in cluster config
+ if (cloudConfig.isCloudEnabled()
Review comment:
1. Please note that we are updating two different paths. The new information
will be added to cluster config. So eventually we need two accesses. one for
the cloud config and one for the cluster config.
2. Our plan is to populate these information while creating the cluster and
all of the paths (REST and java) to create cluster should pass through this
part of the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
