pkuwm commented on issue #846: Make ZKHelixAdmin and ZKHelixManager Realm-aware URL: https://github.com/apache/helix/pull/846#issuecomment-595873589 > Looks good to me. > > Also I think it would be a good idea to test the Builder for HelixAdmin to make sure the Builder creates a working HelixAdmin (or ConfigAccessor, etc.). I am trying to think of ways to do this in other PRs too. Let us think about it. > > Totally fine to do that in a separate PR. As I mentioned, I have the same plan to test and would like to do it for all of the required Java APIs in another PR.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
