pkuwm commented on a change in pull request #846: Make ZKHelixAdmin and
ZKHelixManager Realm-aware
URL: https://github.com/apache/helix/pull/846#discussion_r391034890
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZkBaseDataAccessor.java
##########
@@ -102,14 +103,13 @@ public AccessResult() {
private static Logger LOG =
LoggerFactory.getLogger(ZkBaseDataAccessor.class);
- private final HelixZkClient _zkClient;
+ private final RealmAwareZkClient _zkClient;
// true if ZkBaseDataAccessor was instantiated with a HelixZkClient, false
otherwise
// This is used for close() to determine how ZkBaseDataAccessor should close
the underlying
// ZkClient
private final boolean _usesExternalZkClient;
- @Deprecated
- public ZkBaseDataAccessor(HelixZkClient zkClient) {
+ public ZkBaseDataAccessor(RealmAwareZkClient zkClient) {
Review comment:
Good catch. It should be. When I started working on it, I was not sure and
thought we would keep the new `RealmAwareZkClient ` and deprecate
`HelixZkClient ` instead. I already deprecated in the ZkBaseDataAccessor PR.
Updated to deprecate it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
