narendly commented on a change in pull request #861: Make ClusterSetup realm-aware URL: https://github.com/apache/helix/pull/861#discussion_r389152966
########## File path: helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java ########## @@ -135,37 +138,74 @@ public static final String removeConstraint = "removeConstraint"; private static final Logger _logger = LoggerFactory.getLogger(ClusterSetup.class); - private final String _zkServerAddress; - private final HelixZkClient _zkClient; - // true if ZkBaseDataAccessor was instantiated with a HelixZkClient, false otherwise + private String _zkServerAddress; Review comment: If the user wants to create this class on multi-realm mode, FederatedZkClient will be used. FederatedZkClient does not and should not expose ZkAddress because it's an internal state info. In fact, this `_zkServerAddress` was not being used anywhere and doesn't need to exist. I've removed this field from this class for further safety. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
