pkuwm commented on a change in pull request #861: Make ClusterSetup realm-aware URL: https://github.com/apache/helix/pull/861#discussion_r391070289
########## File path: helix-common/src/main/java/org/apache/helix/SystemPropertyKeys.java ########## @@ -57,4 +60,7 @@ // MBean monitor for helix. public static final String HELIX_MONITOR_TIME_WINDOW_LENGTH_MS = "helix.monitor.slidingTimeWindow.ms"; + + // Multi-ZK mode enable/disable flag + public static final String MULTI_ZK_ENABLED = "helix.multiZkEnabled"; Review comment: I understand there is no rule for naming convention for a property key. But are we considering xxx.yyy.zzz in lowercase ? I would prefer this way as it is more readable, commonly used and easier to troubleshoot. I prefer this way. Just 2 cents ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
