jiajunwang commented on a change in pull request #834: Complete the Routing
Table Provider for CustomizedView
URL: https://github.com/apache/helix/pull/834#discussion_r390013945
##########
File path:
helix-core/src/main/java/org/apache/helix/spectator/RoutingTableProvider.java
##########
@@ -305,8 +461,23 @@ public Object removeRoutingTableChangeListener(
*/
public List<InstanceConfig> getInstancesForResourceGroup(String
resourceGroupName,
String partitionName, String state) {
- return
_routingTableRef.get().getInstancesForResourceGroup(resourceGroupName,
partitionName,
- state);
+ String key = getRoutingTableKey();
+ return
_routingTableRef.get(key).get().getInstancesForResourceGroup(resourceGroupName,
+ partitionName, state);
+ }
+
+ public List<InstanceConfig> getInstancesForResourceGroup(String
resourceGroupName,
Review comment:
Same here. If not in the design, let's hold this for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
