jiajunwang commented on a change in pull request #834: Complete the Routing
Table Provider for CustomizedView
URL: https://github.com/apache/helix/pull/834#discussion_r390006867
##########
File path:
helix-core/src/main/java/org/apache/helix/spectator/RoutingTable.java
##########
@@ -38,42 +39,62 @@
import org.slf4j.LoggerFactory;
/**
- * A class to consume ExternalViews of a cluster and provide {resource,
partition, state} to
- * {instances} map function.
+ * A class to consume ExternalViews or CustomizedViews of a cluster and provide
+ * {resource, partition, state} to {instances} map function.
*/
class RoutingTable {
private static final Logger logger =
LoggerFactory.getLogger(RoutingTable.class);
// mapping a resourceName to the ResourceInfo
private final Map<String, ResourceInfo> _resourceInfoMap;
+
// mapping a resource group name to a resourceGroupInfo
private final Map<String, ResourceGroupInfo> _resourceGroupInfoMap;
private final Collection<LiveInstance> _liveInstances;
- private final Collection<InstanceConfig> _instanceConfigs;
+ protected final Collection<InstanceConfig> _instanceConfigs;
private final Collection<ExternalView> _externalViews;
+ private final PropertyType _propertyType;
+
public RoutingTable() {
Review comment:
Is this one deprecated?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
