pkuwm commented on a change in pull request #855: Make ZkBaseDataAccessor 
realm-aware
URL: https://github.com/apache/helix/pull/855#discussion_r390732665
 
 

 ##########
 File path: 
helix-core/src/main/java/org/apache/helix/manager/zk/ZkBaseDataAccessor.java
 ##########
 @@ -199,20 +238,13 @@ public ZkBaseDataAccessor(String zkAddress, ZkSerializer 
zkSerializer,
    * @param pathBasedZkSerializer
    * @param zkClientType
    */
-  public ZkBaseDataAccessor(String zkAddress, PathBasedZkSerializer 
pathBasedZkSerializer,
+  public ZkBaseDataAccessor(String zkAddress,
 
 Review comment:
   As discussed offline, we don't want the fallback behavior and also make 
these old constructors deprecated.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to