narendly commented on a change in pull request #855: Make ZkBaseDataAccessor
realm-aware
URL: https://github.com/apache/helix/pull/855#discussion_r391347427
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZkBaseDataAccessor.java
##########
@@ -198,21 +271,17 @@ public ZkBaseDataAccessor(String zkAddress, ZkSerializer
zkSerializer,
* @param zkAddress
* @param pathBasedZkSerializer
* @param zkClientType
+ *
+ * @deprecated it is recommended to use the builder constructor {@link
Builder}
*/
- public ZkBaseDataAccessor(String zkAddress, PathBasedZkSerializer
pathBasedZkSerializer,
+ @Deprecated
+ public ZkBaseDataAccessor(String zkAddress,
+ org.apache.helix.zookeeper.zkclient.serialize.PathBasedZkSerializer
pathBasedZkSerializer,
Review comment:
I'd prefer to leave it as is and tackle this later. This sort of refactoring
doesn't have to be in the scope of this PR. Having 2 constructors is fine for
now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
