pkuwm commented on a change in pull request #883: Support enableCompression in
workflow and job configs
URL: https://github.com/apache/helix/pull/883#discussion_r391247480
##########
File path: helix-core/src/main/java/org/apache/helix/task/JobConfig.java
##########
@@ -553,7 +556,11 @@ public static Builder fromMap(Map<String, String> cfg) {
}
if (cfg.containsKey(JobConfigProperty.RebalanceRunningTask.name())) {
b.setRebalanceRunningTask(
-
Boolean.valueOf(cfg.get(JobConfigProperty.RebalanceRunningTask.name())));
+
Boolean.parseBoolean(cfg.get(JobConfigProperty.RebalanceRunningTask.name())));
+ }
+ if (cfg.containsKey(ZNRecord.ENABLE_COMPRESSION_BOOLEAN_FIELD)) {
Review comment:
It is redundant to check `containsKey`: if the value is not set,
parseBoolean still returns false.
Unless the default value enableCompression is true, but I don't think this
should be the case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
