narendly commented on issue #883: Support enableCompression in workflow and job configs URL: https://github.com/apache/helix/pull/883#issuecomment-598015461 > > > Do we want to just add this field or support a builder can carry over all the fields from JobConfig? > > > > > > Just this field only because we want to curb the way user creates workflows and jobs now. Users should ideally use PropertyStore to store user-generated custom fields. > > Can we add a log to tell users their properties are ignored if any? I think that would be helpful for the end users. I don't think adding logs is necessary. Logs are helpful for leaving historical information that can't be found anywhere else. In this case, however, users can easily check whether their fields ever made it to the znode by inspecting the znode. Also, we want to limit the kind of fields we allow users to include in workflow and job config znodes by having them use Builders. The biggest worry of all is again for heavy users of Task Framework, this might pollute the log.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
