jiajunwang commented on a change in pull request #851: Modify Helix generic
controller to include new stage for customized view aggregation
URL: https://github.com/apache/helix/pull/851#discussion_r394690807
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -1072,6 +1146,15 @@ protected void
checkLiveInstancesObservation(List<LiveInstance> liveInstances,
}
}
+ List<String> customizedStates = getEnabledCustomizedStates(manager);
+ for (String customizedState: customizedStates) {
+ for (String instance : curInstances.keySet()) {
+ if (lastInstances == null || !lastInstances.containsKey(instance)) {
+ addCustomizedStateListeners(manager, customizedState, instance);
Review comment:
When you have add, we should have a corresponding remove to prevent listener
leakage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
