zhangmeng916 commented on issue #851: Modify Helix generic controller to include new stage for customized view aggregation URL: https://github.com/apache/helix/pull/851#issuecomment-601939430 > One more thing, the added test cases are not enough. Please add tests for the following features: > > 1. We need to add a case in the test listener leakage for the new listener introduced. This one is tested in TestZkCallbackHandlerLeak. > 2. Admin change to create the new paths. This one is tested in TestZkHelixAdmin. > 3. In the integration test, please test adjusting the view config and see if the view changed accordingly. Moreover, we should use the customized view provider to test. Tested in TestComputeAndCleanupCustomizedView. The provider has unit test checked in, and the end to end integration test will cover from provider to router, which will be checked in by @mgao0. > 4. Try to cover some error case, for example, instances are not reporting the configured type. Or 2 instances are reporting different sets of types. Added test cases in TestComputeAndCleanupCustomizedView > Please try to cover all the use cases that we mentioned in the design doc.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
