kaisun2000 opened a new pull request #924: WIP: fix ZkHelixPropertyStore loses Zookeeper notification issue URL: https://github.com/apache/helix/pull/924 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR description: Fixes #921 ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: ZkHelixPropertyStore loses ZK notification after session expires. The issue was caused by a bug in Share ZkClient code path. More specifically, Share ZkClient would not call fireAllEvent when ZK session expires. Thus, ZkHelixPropertyStore would not install watches for corresponding ZkPath. Thus, lose Zookeeper nofiticaition when changes happens. ### Tests - [x] The following tests are written for this issue: testSessionExpirationWithSharedZkClient - [ ] The following is the result of the "mvn test" command on the appropriate module: Test still running, while attach the result here later, please review first. ### Commits - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - [x] My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
